Repository navigation
Conversation
spucillo
requested review from
BongHwi,
alcaliva,
alibuild,
ercolessi,
iravasen,
lbariogl,
lbarnby,
lhusova,
njacazio,
romainschotter and
skundu692
as code owners
November 13, 2026 18:10
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/code-check for 4620b42 at 2026-11-13 19:19: Full log here. |
spucillo
added a commit
to spucillo/O2Physics
that referenced
this pull request
Nov 13, 2026
[Tutorial,PWGLF] Please consider the following formatting changes to AliceO2Group#18740
Collaborator
|
Error while checking build/O2Physics/code-check for 669a8b9 at 2026-11-13 19:27: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 23ac5cd at 2026-11-13 19:33: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 6907bed at 2026-11-13 19:33: Full log here. |
[Tutorial,PWGLF] [MegaLinter] Apply linters automatic fixes to AliceO2Group#18740
romainschotter
requested changes
Nov 13, 2026
Collaborator
There was a problem hiding this comment.
Hi @spucillo ! Thank you very much for preparing the hands-on tasks!
It looks great!
I just have a few comments:
- Since these are all tasks running over derived data, could you put everything within
Tutorials/PWGLF/Strangeness/Derived - could you also rename the folder
o2physics/AnalysisV0intoAnalysisV0? (since we are already working withinO2Physics). Similarly, the existing folderAnalysiswithinTutorials/PWGLF/Strangeness/Derivedcould be renamedAnalysisCascade - could you please remove the
input_data.txtandinput_MC.txt? We usually don't put them in O2Physics and just provide them in slides for the hands-on session.
Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.